DYN-7766: Review Python packages shipped with the PythonNet3 engine #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusongit
requested review from
Copilot and
twastvedt
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for six new Python libraries (shapely, alphashape, comtypes, scikit-learn, ifcopenshell, tabulate) to the PythonNet3 engine. It includes proper license documentation and handles comtypes threading requirements.
- Adds six new Python packages to the requirements with appropriate version constraints
- Implements apartment state detection and environment configuration for comtypes compatibility
- Provides comprehensive test coverage for all new libraries
Reviewed Changes
Copilot reviewed 4 out of 45 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| DSPythonNet3Wheels/requirements.txt | Adds version specifications for the six new Python libraries |
| DSPythonNet3/DSPythonNet3Evaluator.cs | Adds comtypes apartment state detection and configuration |
| DSpythonNet3Tests/PythonLibraryTests.cs | Adds unit tests for all new libraries to verify availability and basic functionality |
| DSPythonNet3/THIRD_PARTY_NOTICES.txt | Adds comprehensive license information for new libraries and dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
twastvedt
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses DYN-7766
Changes add the required Python libraries:
The wheels were added to the Resources folder in DSPythonNet3Wheels following the existing pattern, and they remain tracked in Git as before.
A small update was made in DSPythonNet3Evaluator to handle comtypes correctly. The evaluator now checks the current .NET thread apartment and sets the COMTYPES_APARTMENT environment variable to match.
The THIRD_PARTY_NOTICES.txt file was updated to include license information for the new libraries and any additional dependencies.
Unit tests were also added.
Total size of wheels resources : 113mb (increased from 89mb)
@zeusongit
@twastvedt