Skip to content

Conversation

@madelinefruin
Copy link
Contributor

please approve it

Copy link
Member

@AdinAck AdinAck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left some notes for some simple changes

Copy link
Member

@AdinAck AdinAck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple more things

@madelinefruin
Copy link
Contributor Author

Changing the png to have a white background lessened the quality a little :(

@AdinAck
Copy link
Member

AdinAck commented Nov 26, 2024

Changing the png to have a white background lessened the quality a little :(

That's ok it looks great!

This tutorial looks good! I'll merge it now.

Good work!

@madelinefruin
Copy link
Contributor Author

Slay, thank you!

@AdinAck AdinAck force-pushed the main branch 2 times, most recently from c593926 to cdf46f7 Compare November 26, 2024 17:14
@AdinAck AdinAck merged commit 10da91b into ECE-196:main Nov 26, 2024
@madelinefruin
Copy link
Contributor Author

Btw, you might want to make an announcement about making the fork here thing because 4 or 5 other groups forked from where we originally had everything. And as of right now, I can't see any other forks from docs.

@AdinAck
Copy link
Member

AdinAck commented Nov 26, 2024

Btw, you might want to make an announcement about making the fork here thing because 4 or 5 other groups forked from where we originally had everything. And as of right now, I can't see any other forks from docs.

Yes I updated the instructions to directly link to the docs repo minutes after you showed me the ambiguity. Thanks!

@AdinAck
Copy link
Member

AdinAck commented Nov 26, 2024

here is your tutorial on the web! congrats on being the first!

LeoNaab pushed a commit that referenced this pull request Jun 16, 2025
LeoNaab pushed a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants