feat(device_manager): reset connectivity#74
Conversation
Th3Un1q3
left a comment
Th3Un1q3
left a comment
There was a problem hiding this comment.
There are a few things to fix before it's ready.
Make sure PR follows:
https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit-body
No exclamation mark, scope of change, description of breaking change.
|
|
||
| Manage device connectivity | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
There was a problem hiding this comment.
Leave a link to connectivity troubleshooting https://www.emnify.com/developer-blog/5-ways-to-detect-and-solve-connectivity-issues#network-events
|
|
||
| class DeviceConnectivityStatus(BaseModel): | ||
| """ | ||
| Model for device connectivity status |
There was a problem hiding this comment.
No need in such a literal comment. It does not add any info.
Consider what else would user need to know about this class. For example what is connectivity status?
| def test_reset_connectivity(self): | ||
| emnify = emnify_client(app_token=self.token) | ||
| device_id = 12132821 | ||
| emnify.devices.reset_connectivity_data(device_id=device_id) |
There was a problem hiding this comment.
Does it make sense to test response here?
| def test_reset_connectivity_network(self): | ||
| emnify = emnify_client(app_token=self.token) | ||
| device_id = 12132821 | ||
| emnify.devices.reset_connectivity_network(device_id=device_id) |
|
|
||
| def reset_connectivity_network(self, device_id: int) -> True: | ||
| """ | ||
| Method for resetting device connectivity network |
There was a problem hiding this comment.
Here and below comments are not descriptive.
|
Kudos, SonarCloud Quality Gate passed! |
Th3Un1q3
changed the title
2 participants
No description provided.