Fix bugs in python table writing and checking scripts#32
Merged
nusbaume merged 3 commits intoESCOMP:mainfrom Apr 27, 2023
Merged
Fix bugs in python table writing and checking scripts#32nusbaume merged 3 commits intoESCOMP:mainfrom
nusbaume merged 3 commits intoESCOMP:mainfrom
Conversation
Collaborator
Author
|
@mkavulich I sent you an invite to join this repo in order to add you as a reviewer. Of course if you would prefer to not review this PR (or generally don't want to review PRs in this repo) then just let me know. Thanks! |
mkavulich
approved these changes
Mar 30, 2023
Collaborator
mkavulich
left a comment
mkavulich
left a comment
There was a problem hiding this comment.
I haven't tested this myself but the code changes look good to me.
mkavulich
approved these changes
Mar 30, 2023
grantfirl
approved these changes
Apr 10, 2023
cacraigucar
approved these changes
Apr 26, 2023
Collaborator
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
Tested with a duplicate name and it worked as advertised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the xml_tools library to allow the use of python 3.7+ when using
write_standard_name_table.py. Also fixed the use of the--overwriteflag incheck_xml_unique.py.Fixes #30
Fixes #31
Tests run:
Ran tests with
check_xml_unique.pyandcheck_xml_unique.py --overwritewhere duplicate variables were added to both the same section and to different sections ofstandard_names.xml, to make sure the script worked as expected.Also ran
write_standard_name_table.pyon a modifiedstandard_names.xmlfile to make sure the Markdown file was created successfully. This was done with python 3.9.4, 3.10.8, and 2.7.17 to try and test that the script works with multiple versions, including versions newer than 3.6.Finally, I again wasn't sure who to add as reviewers, so please feel free to expand or modify the reviewer list if need be.