Skip to content

adding filename for micm#40

Merged
mkavulich merged 2 commits intoESCOMP:mainfrom
K20shores:musica_micm_names
Oct 24, 2023
Merged

adding filename for micm#40
mkavulich merged 2 commits intoESCOMP:mainfrom
K20shores:musica_micm_names

Conversation

@K20shores
Copy link
Copy Markdown
Contributor

@K20shores K20shores commented Jun 13, 2023

Adds a standard name that will enable a CCPP compliant model to pass a configuration file necessary to run the micm solver to solve chemistry.

@K20shores K20shores marked this pull request as draft July 12, 2023 15:56
@nusbaume nusbaume marked this pull request as ready for review October 16, 2023 19:53
@climbfuji climbfuji removed their request for review October 16, 2023 21:33
Comment thread standard_names.xml
@mkavulich
Copy link
Copy Markdown
Collaborator

@K20shores Looks good to me, can you add a brief description/purpose of these changes for posterity? Thanks!

@K20shores
Copy link
Copy Markdown
Contributor Author

@K20shores Looks good to me, can you add a brief description/purpose of these changes for posterity? Thanks!

done!

Copy link
Copy Markdown
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K20shores Thanks! Merging now.

@mkavulich mkavulich merged commit d8b060d into ESCOMP:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants