Fix #292: Upload handler was not called when an empty file was uploaded. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploading an empty file is a valid use case. Ref: #292
mathieucarbou
force-pushed
the
issue/292
branch
from
0c5d303 to
0ee9090
Compare
willmmiles
approved these changes
Sep 25, 2025
willmmiles
left a comment
willmmiles
left a comment
There was a problem hiding this comment.
Looks OK to me. I have no objections to the semantic change for 0 byte files - this seems like a good fix. (I have not personally had time to run any test cases.)
me-no-dev
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading an empty file is a valid use case.
Ref: #292