Skip to content

change to use module_indices #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

change to use module_indices #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c9518
change to use module_indices
KrisThielemans Nov 5, 2024
6daeb36
use temp variable to increase readability
KrisThielemans Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions python/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def set_module_color(


def create_mesh(header, modules_only=False, show_det_eff=False, random_color=False, fov=None,
num_modules=0, skip_modules=0):
modules_indices=None):
"""
Create 3D model of PET scanner defined in PETSIRD list mode file.
"""
Expand All @@ -182,8 +182,8 @@ def create_mesh(header, modules_only=False, show_det_eff=False, random_color=Fal
rep_module.object.detecting_elements
) # Get all the detecting elements modules
for mod_i in range(len(rep_module.transforms)):
if (module_count % (skip_modules + 1)) > 0:
module_count += 1
module_count += 1
if modules_indices is not None and (module_count - 1) not in modules_indices:
continue

vertices = [] # If showing modules only
Expand Down Expand Up @@ -222,10 +222,6 @@ def create_mesh(header, modules_only=False, show_det_eff=False, random_color=Fal

shapes.append(module_mesh)

module_count += 1
if num_modules > 0 and module_count + skip_modules + 1 > (num_modules * (skip_modules + 1)):
break

if fov is not None:
shapes.append(
trimesh.creation.cylinder(radius=fov[0], height=fov[1])
Expand Down Expand Up @@ -308,6 +304,8 @@ def parserCreator():

if __name__ == "__main__":
args = parserCreator()
if args.skip_modules < 0:
sys.exit('skip_modules should be >= 0')

file = None
if args.input is None:
Expand All @@ -318,9 +316,10 @@ def parserCreator():

with petsird.BinaryPETSIRDReader(file) as reader:
header = reader.read_header()

module_indices = range(0, args.num_modules * (args.skip_modules + 1), args.skip_modules + 1) if args.num_modules > 0 else None
mesh = create_mesh(header, args.modules_only, args.show_det_eff, args.random_color, args.fov,
args.num_modules, args.skip_modules)
module_indices
)
mesh.export(output_fname)

# Forced to do this
Expand Down