This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Refactor configurations #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mriyam Tamuli <mbtamuli@gmail.com>
rahul286
reviewed
Jan 16, 2018
| @@ -1,4 +1,7 @@ | |||
| wordpress | |||
| data | |||
| app | |||
There was a problem hiding this comment.
Most frameworks already uses app dir for specific codes. e.g. https://laravel.com/docs/5.5/structure
If we use this then users will have to cd ..../app/app/.....
So can we think of an alternative? e.g. web, source
There was a problem hiding this comment.
or maybe keep wordpress for now 😃
rahul286
reviewed
Jan 16, 2018
| @@ -1,4 +1,7 @@ | |||
| wordpress | |||
| data | |||
| app | |||
There was a problem hiding this comment.
or maybe keep wordpress for now 😃
|
|
||
| client_max_body_size 100m; | ||
| include includes/wpsubdir.conf; | ||
| include /etc/nginx/sites-enabled/*; |
There was a problem hiding this comment.
why we need this? Every app will be a single nginx? Or is this related to front-end proxy?
|
I have noticed some minor issues but merging this PR for now. I would prefer to test new refactored version first and then decide if changes are really needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the configuration to enable a single docker-compose.yml to serve all types, single site or wp-multisite