Fix migration into individual package #1209
Conversation
sagarnasit
changed the title
php/EE/Migration/Executor.php
Outdated
| } | ||
|
|
||
| private static function get_migrations_to_execute() { | ||
| private static function get_migrations_to_execute( $path ) { |
There was a problem hiding this comment.
Add doc comment in function
php/EE/Migration/Executor.php
Outdated
| ); | ||
| } | ||
|
|
||
| private static function get_migrations_from_db() { |
There was a problem hiding this comment.
Add doc comment in function
php/EE/Migration/Executor.php
Outdated
| } | ||
|
|
||
| private static function get_migrations_from_fs() { | ||
| private static function get_migrations_from_fs( $path ) { |
There was a problem hiding this comment.
Add doc comment in function
php/EE/Migration/Executor.php
Outdated
| } | ||
| } | ||
|
|
||
| private static function get_migration_class_name( $migration_name ) { |
There was a problem hiding this comment.
Add doc comment in function
|
inform users that migrations are picked up from filesystem based on package name and inform where code is trying to find migration. https://github.com/EasyEngine/easyengine/pull/1209/files#diff-bfc37b6395768a2f0ee3bc8a300c5fceR78 |
sagarnasit
force-pushed
the
develop-v4
branch
from
86ce264 to
2deeeac
Compare
sagarnasit
changed the title
sagarnasit
changed the title
|
The PR is fine but we need to discuss how do we trigger migrations for the first time. Hence I'm blocking this PR for now. |
sagarnasit
changed the title
|
@kirtangajjar Please review this PR again as this is updated with latest migration changes from PR #1224 |
| use EE\Model\Migration; | ||
| use EE\Utils; | ||
|
|
||
| class Executor { |
There was a problem hiding this comment.
Unless string interpolation is required, use single quotes.
This should have been flagged by PHPCS ideally. If it has not on your machine, ping me tommorow, well set it up.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh okay. I didn't fix those PHPCS errors intentionally #1124 since this PR of @sagarnasit was already there and I informed him to take care of fixes.
| * @package EE\Migration | ||
| */ | ||
| class Blank extends \EE\Migration\Base { | ||
| class Test extends \EE\Migration\Base { |
sagarnasit
dismissed stale reviews from mrrobot47 and rahulsprajapati
via
9d677ed
5 participants
Fixes #1203
Depends on:
EasyEngine/auth-command#9
Move migration execution in individual packages. Change migration execution logic for package migratoin as well.