Skip to content

Make get and set methods in Option model static #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Make get and set methods in Option model static #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions php/EE/Model/Option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Option extends Base {
* @throws \Exception
* @return bool Key set or not
*/
public function set( string $key, string $value ) {
public static function set( string $key, string $value ) {
$existing_key = static::find( $key );

if ( empty( $existing_key ) ) {
Expand All @@ -45,7 +45,7 @@ public function set( string $key, string $value ) {
* @throws \Exception
* @return bool|Option
*/
public function get( string $key ) {
public static function get( string $key ) {
$option = static::find( $key );

return false === $option ? false : $option->value;
Expand Down