Skip to content

Add support for PHP 5.6 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Add support for PHP 5.6 #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4a663
Add php5.6 image version
mrrobot47 Nov 21, 2018
8bff8e0
Skip pulling of 5.6 image temporarily
mrrobot47 Nov 21, 2018
6891a70
Update 5.6 image check
mrrobot47 Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions img-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"easyengine/nginx-proxy": "v4.0.0",
"easyengine/nginx": "v4.0.0",
"easyengine/php": "v4.0.0",
"easyengine/php5.6": "v4.0.0",
"easyengine/postfix": "v4.0.0",
"easyengine/redis": "v4.0.0"
}
3 changes: 3 additions & 0 deletions migrations/db/20181016052850_easyengine_insert_docker_images_version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ public function up() {

$query = '';
foreach ( $images as $image => $tag ) {
if ( 'easyengine/php5.6' === $image ) {
continue;
}
EE::log( "Checking and Pulling docker image $image:$tag" );
if ( ! \EE::exec( "docker pull ${image}:${tag}", true, true ) ) {
throw new \Exception( "Unable to pull ${image}:${tag}. Please check logs for more details." );
Expand Down
3 changes: 3 additions & 0 deletions php/EE/Migration/Containers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ public static function start_container_migration() {
$updated_images = [];

foreach ( $img_versions as $img => $version ) {
if ( 'easyengine/php5.6' === $img ) {
continue;
}
if ( $current_versions[ $img ] !== $version ) {
$updated_images[] = $img;
self::pull_or_error( $img, $version );
Expand Down