Cache only certain response codes #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep fastcgi cache from mistakenly caching (and then serving) 5XX error pages and other things it shouldn't, only cache pages with a 200 response code.
Member
|
@gau1991 merge this in current EE2 as well as future EE 3 release with similar changes. Please share EE3 changes commit link here, so I can review it. |
gau1991
pushed a commit
that referenced
this pull request
Jan 21, 2015
Cache only certain response codes
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastcgi cache should only cache pages with certain http response codes instead of "any" which can sometimes cache transient 5XX error pages. this patch changes the caching behavior so that it only caches 200, 301, 302, and 404.
see http://community.rtcamp.com/t/fascgi-cache-caching-error-pages/3847