Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Nov 19, 2025

Description

After much research (online articles, consulting AI, reviewing other large client libraries that don't use it), I determined the dispose logic is not necessary. The C# HTTP client under the hood handles its own dispose and our service objects are not large enough to warrant any real memory issues. A lot of this was noise and most likely did not have a meaningful improvement on memory management.

Separately, the client service instantiation was moved inline to reduce complexity as it was also determined that instantiating them in the constructor vs inline had no real performance implications.

Finally, I fixed the added but yet released RetrieveBatch function to use the parameter set instead of a dictionary. We are moving to have this library only support parameter sets moving forward (eg: ClaimService) which is the newest service added does not have any functions that accept a dictionary, so adjusted the parameter definition.

Finally finally... fixes a nasty compiler error with the Dictionaries file I had to track down.

Testing

Tests pass and re-recorded the new retrieve batch cassette verifying that the adjustment to service instantiation works.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested review from a team as code owners November 19, 2025 23:15
@Justintime50 Justintime50 marked this pull request as draft November 20, 2025 00:19
@Justintime50 Justintime50 marked this pull request as ready for review November 20, 2025 20:39
Copy link
Member

@stephenjwatkins stephenjwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as i can tell!

@Justintime50 Justintime50 merged commit 93aa101 into master Nov 21, 2025
17 checks passed
@Justintime50 Justintime50 deleted the client_cleanup branch November 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants