Skip to content

fix: releasing workflow #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Justintime50 merged 1 commit into from
Dec 2, 2025
Merged

fix: releasing workflow #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/manual_release_prep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
uses: actions/setup-dotnet@v5
with:
dotnet-version: |
5.x.x
6.x.x
7.x.x
8.x.x
9.x.x
10.x.x

- name: Setup Nuget
uses: NuGet/setup-nuget@v2
Expand Down Expand Up @@ -63,10 +63,10 @@ jobs:

- name: Build and Sign NuGet package
run: |
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" Release
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" "${{ secrets.SM_CODE_SIGNING_CERT_SHA256_HASH }}" Release
shell: cmd

- name: Upload NuGet package to Action output
uses: actions/upload-artifact@v4
with:
path: "*.nupkg"
path: '*.nupkg'
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
uses: actions/setup-dotnet@v5
with:
dotnet-version: |
5.x.x
6.x.x
7.x.x
8.x.x
9.x.x
10.x.x

- name: Setup Nuget
uses: NuGet/setup-nuget@v2
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Build and Sign NuGet package
run: |
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" Release
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" "${{ secrets.SM_CODE_SIGNING_CERT_SHA256_HASH }}" Release
shell: cmd

- name: Publish to NuGet
Expand All @@ -73,5 +73,5 @@ jobs:
- name: Upload NuGet package to release
uses: AButler/upload-release-assets@v3.0.1
with:
files: "*.nupkg"
files: '*.nupkg'
repo-token: ${{ secrets.GITHUB_TOKEN }}
9 changes: 5 additions & 4 deletions scripts/win/build_release_nuget.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
:: Parse command line arguments
SET projectName=%1
SET strongNameCertFile=%2
SET authCertFingerprint=%3
SET buildMode=%4
SET authCertSha1Fingerprint=%3
SET authCertSha256Fingerprint=%4
SET buildMode=%5

:: Delete old files
CALL "scripts\win\delete_old_assemblies.bat"
Expand All @@ -24,13 +25,13 @@ CALL "scripts\win\build_project.bat" %buildMode% || GOTO :commandFailed
CALL "scripts\win\strong_name_dlls.bat" %strongNameCertFile% || GOTO :commandFailed

:: Sign the DLLs for authenticity
CALL "scripts\win\sign_dlls.bat" %authCertFingerprint% || GOTO :commandFailed
CALL "scripts\win\sign_dlls.bat" %authCertSha1Fingerprint% || GOTO :commandFailed

:: Package the DLLs in a NuGet package (will fail if DLLs are missing)
CALL "scripts\win\pack_nuget.bat" %projectName% || GOTO :commandFailed

:: Sign the NuGet package for authenticity
CALL "scripts\win\sign_nuget.bat" %authCertFingerprint% || GOTO :commandFailed
CALL "scripts\win\sign_nuget.bat" %authCertSha256Fingerprint% || GOTO :commandFailed
SET nugetFileName=
FOR /R %%F IN (*.nupkg) DO (
SET nugetFileName="%%F"
Expand Down
Loading