Skip to content

Conversation

@nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Aug 16, 2024

Description

While this is a bug fix, the fix itself is significant enough from a risk perspective to warrant a minor version bump.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@nwithan8 nwithan8 requested a review from a team August 16, 2024 19:00
Copy link
Contributor

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a minor version bump as well

@nwithan8 nwithan8 merged commit a4c741f into master Aug 16, 2024
@nwithan8 nwithan8 deleted the prep_release branch August 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants