Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Nov 7, 2025

Description

The go environment has changed a bunch in the last couple years since this was setup. As written, goveralls can no longer install properly. By installing it as a binary instead of a module, we correct the goveralls install and allow it to report coverage to coveralls correctly again.

Testing

I ran this without the master branch check and the report got uploaded correctly.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@Justintime50 Justintime50 marked this pull request as ready for review November 7, 2025 20:51
@Justintime50 Justintime50 requested review from a team as code owners November 7, 2025 20:51
@Justintime50 Justintime50 merged commit b132467 into master Nov 7, 2025
29 of 39 checks passed
@Justintime50 Justintime50 deleted the fix_coveralls branch November 7, 2025 20:58
Copy link

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah chill with these huge PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants