Add optional fn_print to Session::login_session_file #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehkillerbee
requested changes
Sep 29, 2024
Collaborator
tehkillerbee
left a comment
tehkillerbee
left a comment
There was a problem hiding this comment.
There are some linter errors that must be fixed as well, then it can be merged in.
- I never thought it could be the comma
GioF71
deleted the
feature/login-session-file-add-optional-print-function-282
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed, I have added the optional fn_print argument. The typing is the same used in login_pkce, so it's simply Callable[[str], None], but this should be good enough for the task.
Feel free to ask for any changes might be needed, thank you.