-
Notifications
You must be signed in to change notification settings - Fork 367
Add a custom property
#552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What is the motivation? |
|
@akosyakov mostly testing, but it should fix publishing some harder Microsoft extensions, specifically https://github.com/microsoft/vscode-js-profile-visualizer, because it requires the deps install to never occur, because if you do Edit: this now also fixes https://github.com/formulahendry/vscode-auto-rename-tag, which has never successfully published to OpenVSX (8M downloads) |
|
I just wonder we already have |
|
Actually, using the Sadly, two issues arise with this: Firstly, the extension also requires a Secondly, the manifest path is derived from the |
neurolag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome to me - I'm looking forward to have the profiler (and stuff like jupyter) running in Codium at some point! 😄
There's one small change I'd like to see in this PR
neurolag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you don't mind me interrupting once more. I think it might be a good idea to let the devs choose whether to provide a custom array or a string.
Looks great 😄
Co-authored-by: Manuel Thalmann <m@nuth.ch>
…blish-extensions into ft/add-custom-option
…blish-extensions into ft/add-custom-option
This PR introduces a
customproperty available to extensions to let them have an entirely customized process, because not all extensions are built the same, meaning even some of the biggest ones we have are failing.This PR adds a very powerful option, in docs we should make it clear that this should be used as a last measure (we need to favor extensions with no setup, if they require some then we should point to the
prepublishsetting).How to test
Try to execute the following to test that everything is working correctly: