Add main sidebar styles for Quicksilver #197
Conversation
|
Deploy preview for eclipsefdn-solstice-assets ready! Built with commit e860feb https://deploy-preview-197--eclipsefdn-solstice-assets.netlify.app |
ericpoirier
requested review from
autumnfound,
chrisguindon and
flora8984461
flora8984461
left a comment
flora8984461
left a comment
There was a problem hiding this comment.
I think the folder path is not corresponding, one is under less/_components/quicksilver/ while the import is ../_components/main-sidebar.less
|
Are we still using this PR? |
|
@ericpoirier can we close this? |
Eric, can we close this? If not, can we finish this? |
I'll rebase and see if there is more work to be done to close this. |
ericpoirier
force-pushed
the
epoirier/master/add_main_sidebar
branch
from
afeddb3 to
7c85f5c
Compare
ericpoirier
force-pushed
the
epoirier/master/add_main_sidebar
branch
from
7c85f5c to
c602c6e
Compare
ericpoirier
force-pushed
the
epoirier/master/add_main_sidebar
branch
from
c602c6e to
07e6691
Compare
|
As a side note, I started to use this new sidebar on newer sites: ..whatever solution we take, we must make sure not to break older sites with the previous sidebar such as https://jakarta.ee/about/ |
Change-Id: I588a135554529922f2599869fca5fcd166d173e9 Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
Change-Id: Id7a590db2b8c80d0dafd8317da52929cf41b6745 Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
ericpoirier
force-pushed
the
epoirier/master/add_main_sidebar
branch
from
07e6691 to
cde6bdc
Compare
Change-Id: I51c448156ec6ce8030a71dc369f063e72efc8c33 Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
4 participants
Change-Id: I588a135554529922f2599869fca5fcd166d173e9
Signed-off-by: Eric Poirier eric.poirier@eclipse-foundation.org