Change default strings export to named lstrings export #4100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Apr 4, 2023
src/locales/strings.ts
Outdated
Comment on lines
47
to
55
| mergeStrings(out.strings, allLocales[lang]) | ||
| mergeStrings(out.lstrings, allLocales[lang]) | ||
| } | ||
|
|
||
| // Find an exact match | ||
| // @ts-expect-error | ||
| if (allLocales[normalizedLocale] !== undefined) { | ||
| found = true | ||
| // @ts-expect-error | ||
| mergeStrings(out.strings, allLocales[normalizedLocale]) | ||
| mergeStrings(out.lstrings, allLocales[normalizedLocale]) |
There was a problem hiding this comment.
Ditch the "out" variable and just call mergeStrings(lstrings, ...) directly.
| } | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
You accidentally deleted this line!
swansontec
force-pushed
the
jon/fix/lstring-update
branch
from
e4821e1 to
174df35
Compare
Jon-edge
force-pushed
the
jon/fix/lstring-update
branch
from
174df35 to
a8487e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: