Refactor Conversion Tracking #4890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
reviewed
Mar 7, 2024
Jon-edge
force-pushed
the
jon/fix/conversion-tracking
branch
from
b51f2bf to
764b37c
Compare
swansontec
requested changes
Mar 11, 2024
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
This is looking really good now!
We need to do a few more changes, so go ahead and squash the fixups before you do your final round of changes.
| currencyConfig: wallet.currencyConfig | ||
| }) | ||
|
|
||
| const { tokenId, nativeAmount } = cryptoAmount |
Contributor
There was a problem hiding this comment.
Oooh, nice. Your new class may be even more useful than I expected. I like where this is going.
Jon-edge
force-pushed
the
jon/fix/conversion-tracking
branch
2 times, most recently
from
c0a8c68 to
16d1a93
Compare
swansontec
approved these changes
Mar 12, 2024
We call everything `pluginId,` making things ambiguous and confusing when we pass `pluginId` around. In this case it was causing problems with the logging when treating a provider's pluginId as a wallet pluginId. Also refactor reported data to be more explicit about what values mean.
…ll everything `pluginId,` making things ambiguous and confusing when we pass `pluginId` around. In this case it was causing problems with the logging when treating a provider's pluginId as a wallet pluginId.
Jon-edge
force-pushed
the
jon/fix/conversion-tracking
branch
from
16d1a93 to
782af1d
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion tracking was broken in some cases. Wrong values, including our very ambiguous
pluginId, were being used to calculate dollar conversion values. As a result,logEventeither silently failed without sending out the tracking event, or reported the incorrect amount values.Refactor tracking in general, introduce an MVP of
CryptoAmount, and make props more explicit. All of those combined ought to reduce the likelihood of similar future mistakes.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: