max button ramp plugins #5700
Closed
max button ramp plugins #5700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jon-edge
reviewed
Sep 5, 2025
| } else { | ||
| // Toggle on max mode | ||
| setIsMaxAmount(true) | ||
| setLastUsedInput('crypto') |
There was a problem hiding this comment.
Is this intentional for max mode?
Jon-edge
reviewed
Sep 5, 2025
| {/* Bottom Input (Crypto by design) */} | ||
| <InputRow> | ||
| <DropDownInputButton onPress={handleCryptDropdown}> | ||
| {selectedCrypto == null || selectedWallet == null ? ( |
There was a problem hiding this comment.
When no wallet is selected, rendering FlagIcon with an empty URI may show a broken image; consider a placeholder or null.
There was a problem hiding this comment.
We'll make it null
Jon-edge
reviewed
Sep 5, 2025
Comment on lines
643
to
648
| const ts = Math.floor(Date.now() / 1000) | ||
| let socn: string, tacn: string | ||
| let soam: number |
There was a problem hiding this comment.
Improve these var names.
Also, one decl per line.
There was a problem hiding this comment.
Yeah f*ck that noise.
Jon-edge
reviewed
Sep 5, 2025
Comment on lines
1022
to
1055
| const cacheKey = getCacheKey( | ||
| direction, | ||
| fiatCode, | ||
| banxaCoin, | ||
| paymentType, | ||
| amountType | ||
| ) | ||
| const cached = maxAmountCache.get(cacheKey) | ||
| const now = Date.now() | ||
|
|
||
| if (cached && now - cached.timestamp < MAX_CACHE_TTL) { | ||
| maxAmountString = cached.amount | ||
| } else { | ||
| if (amountType === 'fiat') { | ||
| maxAmountString = paymentObj.max | ||
| } else { | ||
| // For crypto, we need to fetch a quote with max fiat to get the crypto amount | ||
| const maxFiatQueryParams: any = { | ||
| account_reference: username, | ||
| payment_method_id: paymentObj.id, | ||
| source: direction === 'buy' ? fiatCode : banxaCoin, | ||
| target: direction === 'buy' ? banxaCoin : fiatCode | ||
| } | ||
| if (direction === 'buy') { | ||
| maxFiatQueryParams.source_amount = paymentObj.max | ||
| } else { | ||
| maxFiatQueryParams.target_amount = paymentObj.max | ||
| } | ||
| const maxResponse = await banxaFetch({ | ||
| method: 'GET', | ||
| url, | ||
| hmacUser, | ||
| path: 'api/prices', | ||
| apiKey, | ||
| queryParams: maxFiatQueryParams | ||
| }) | ||
| const maxPrices = asBanxaPricesResponse(maxResponse) | ||
| maxAmountString = maxPrices.data.prices[0].coin_amount | ||
| } | ||
| // Cache the result | ||
| maxAmountCache.set(cacheKey, { | ||
| amount: maxAmountString, | ||
| timestamp: now |
There was a problem hiding this comment.
Consider a shared cache utility to use across providers
There was a problem hiding this comment.
We've decided over the should to drop caching because we observed that caching was not included as a feature for the original provider plugins architecture.
Jon-edge
reviewed
Sep 5, 2025
Comment on lines
265
to
290
| const decimals = | ||
| denomination?.multiplier.match(/0/g)?.length ?? DECIMAL_PRECISION |
There was a problem hiding this comment.
const decimals = denomination != null ? mulToPrecision(denomination.multiplier) : DECIMAL_PRECISION
|
As with the other PRs, address non-deprecation warnings. |
This is an attempt to get the agent to automatically document lessons learned to the docs/ directory. This way conventions are maintained and over time as the agent is course corrected.
- Create docs/localization-guidelines.md with mandatory UI string localization rules - Create docs/component-styling-guidelines.md with styled HOC usage patterns - Update AGENTS.md with Documentation section indexing all docs/ files - Add rule requiring all docs/ markdown files to be indexed in AGENTS.md - Add localized strings for TradeRegionSelectScene to en_US.ts
This file contains run configuration such as RN_SIMULATOR and RN_PORT to be used by a rn-ios script. This is for development purposes
This is a consistent card design for the new fiat buy UI.
- Implement TradeCreateScene and TradeOptionSelectScene for buy/sell flow - Add Paybis as first ramp plugin with full API integration - Create reusable hooks for ramp plugin management (useRampPlugins, useRampQuotes) - Add payment type icon system with comprehensive mappings - Implement quote fetching and comparison across multiple providers - Add best rate badge component for quote comparison - Create ramp plugin type definitions and store utilities - Add comprehensive documentation for migration and architecture - Include unit tests for payment types and store IDs - Update navigation and deeplink handlers for ramp flows BREAKING CHANGE: Replaces legacy FiatPluginUi with new ramp plugin system
Include plugin IDs in React Query key so quotes refetch when region/currency/wallet changes affect available plugins. Simplify queryFn to always check current plugins while reusing valid cached quotes.
samholmes
force-pushed
the
sam/max-button-ramp-plugins
branch
from
e969e43 to
ba4d205
Compare
samholmes
force-pushed
the
sam/max-button-ramp-plugins
branch
from
ba4d205 to
895bc92
Compare
|
Replaced by #5740 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: