Skip to content

Conversation

@swansontec
Copy link
Contributor

@swansontec swansontec commented Aug 22, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

This component changed in React Native 79, and was not working correctly.
This is based on two commits from the React Native upstream project:

1st: dd12edf35f89aed4872ba40e54fc9caaabfac0bf
2nd: cb20a1cd32c5a9fa79e12223d03b7ade18a890c8

These commits touch a lot of files, but we just need these two:

packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp
packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.h

The other files implement the new feature flag, but we can ignore those
and just hard-code the change to "on".
@swansontec swansontec force-pushed the william/reanimated4 branch from 06caeb7 to d595724 Compare August 25, 2025 20:43
@swansontec swansontec enabled auto-merge August 25, 2025 20:44
@swansontec swansontec merged commit 142ac31 into develop Aug 25, 2025
3 checks passed
@swansontec swansontec deleted the william/reanimated4 branch August 25, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants