Fix long address font scaling #5746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
swansontec
approved these changes
Sep 19, 2025
| if (this.state.minimumPopupModalState[pluginId]) { | ||
| if (this.state.minimumPopupModalState[pluginId] === 'NOT_YET_SHOWN') { | ||
| const popupState = this.state.minimumPopupModalState[pluginId] | ||
| if (popupState != null) { |
There was a problem hiding this comment.
Since the popupState === 'NOT_YET_SHOWN' test implies that popupState != null, you can just delete this line altogether.
| <EdgeText>{fioToAddress + '\n'}</EdgeText> | ||
| )} | ||
| <EdgeText numberOfLines={3}>{recipientAddress}</EdgeText> | ||
| {/* TODO: Make EdgeText component support this use case */} |
There was a problem hiding this comment.
Optional: We do have a component for this use-case, ParagraphText. It gets rid of the whole numberOfLines locking, and simply allows the text to flow as needed. But I see that your solution works too.
Jon-edge
force-pushed
the
jon/fix/unified-address-scale
branch
3 times, most recently
from
00d0a0f to
7dddb18
Compare
swansontec
approved these changes
Sep 19, 2025
swansontec
force-pushed
the
jon/fix/unified-address-scale
branch
from
7dddb18 to
d8b798c
Compare
Jon-edge
force-pushed
the
jon/fix/unified-address-scale
branch
from
d8b798c to
183d125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: