Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Sep 24, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)


Note

Adds Banxa ACH sell support and Moonpay Faster Payments (UK), with provider address handling and webview/deeplink flow refinements.

  • Fiat Providers:
    • Banxa (banxaProvider.ts): Enable sell.ach; add Banxa payment type→ach mapping; switch polling to setInterval; prefer segwit receive addresses; tighten types and error handling.
    • Moonpay (moonpayProvider.ts): Add Faster Payments (gbp_bank_transfer) mapping and support (sell); improve deeplink/webview handlers and validation; minor fetch/US support checks refined.
    • Paybis (paybisProvider.ts): Prefer segwit receive addresses; harden deeplink/onUrlChange handlers and logging.
  • Config:
    • src/constants/plugins/sellPluginList.json: Restrict fasterpayments to GB.
  • CHANGELOG: Note Moonpay Faster Payments support and Banxa ACH sell enabled.

Written by Cursor Bugbot for commit a0e10ae. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few small things.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator Author

@Jon-edge Jon-edge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated per-thread comments

)
return
}
await showUi.showError(e)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Restored specific handling for user cancel (SendErrorBackPressed) and no-transaction (SendErrorNoTransaction), preserving the prior UX. Paybis still prefers segwit: getAddresses returns segwit first when present via the first element publicAddress.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change to address handling, and we're golden.

cursor[bot]

This comment was marked as outdated.

@Jon-edge
Copy link
Collaborator Author

Jon-edge commented Sep 29, 2025

Addressed the latest three comments:

  • paybisProvider: Use getAddresses + Array.find to prefer segwit when present, fallback to default publicAddress. Also removed redundant String(...) around fiat keys.
  • banxaProvider: Same segwit selection via Array.find, and updated usages to avoid stale receiveAddress reference.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, apart from one teeny typo.

@Jon-edge Jon-edge force-pushed the jon/fiat-regions branch 2 times, most recently from 56b580d to 6af5aa7 Compare October 1, 2025 23:28
cursor[bot]

This comment was marked as outdated.

@Jon-edge Jon-edge enabled auto-merge October 3, 2025 04:20
@Jon-edge Jon-edge merged commit 945f09a into develop Oct 3, 2025
3 checks passed
@Jon-edge Jon-edge deleted the jon/fiat-regions branch October 3, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants