Skip to content

Prevent resorting of import that would break RTD builds. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Merge `master` into `stable`.
merged 1 commit into from
Feb 21, 2020
Merged

Prevent resorting of import that would break RTD builds. #376

merged 1 commit into from
Feb 21, 2020

Conversation

@desilinguist
Copy link
Collaborator

🤦‍♂ , sorry.

@pep8speaks
Copy link

Hello @desilinguist! Thanks for opening this PR.

Line 25:1: E402 module level import not at top of file

Do see the Hitchhiker's guide to code style

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.837% when pulling 8b40cc7 on fix-broken-rtd-import into 11326bb on master.

@desilinguist desilinguist merged commit f13b858 into master Feb 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-broken-rtd-import branch February 21, 2020 18:11
srhrshr pushed a commit to srhrshr/rsmtool that referenced this pull request Oct 23, 2021
@desilinguist
Merge pull request EducationalTestingService#376 from EducationalTest…
ecf4606 
…ingService/fix-broken-rtd-import

Prevent resorting of import that would break RTD builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aloukina aloukina aloukina approved these changes

+1 more reviewer

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@desilinguist @pep8speaks @coveralls @mulhod @aloukina