Skip to content

feat: add markdown formatting #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: add markdown formatting #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/PostCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import toast from "react-hot-toast";
import { usePosts } from "../context/postContext";
import ReactMarkdown from "react-markdown";
import { useNavigate } from "react-router-dom";
import moment from "moment";
import logoImg from "../Images/postimg.jpg";
Expand Down Expand Up @@ -123,10 +124,12 @@ export function PostCard({ post }) {

<div className="p-6">
<h2 className="text-xl text-gray-800 font-semibold">{post.title}</h2>
<p className="text-lg font font-thin text-black text-justify">

<ReactMarkdown className="text-lg font font-thin text-black text-justify">
{post.description}
</p>
<h4 className="text-gray-400 capitalize my-2"> Source:{post.source}</h4>
</ReactMarkdown>

<h4 className="text-gray-400 capitalize my-2"> Source:{post.source}</h4>
</div>
</article>
);
Expand Down
14 changes: 9 additions & 5 deletions src/components/PostCardUser.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import moment from "moment";
import ReactMarkdown from "react-markdown";
import { insertMedia } from "./PostCard";
import logoImg from "../Images/postimg.jpg";

export function PostCardUser({ post }) {
const normalDate = moment(post.createdAt).format("DD/MM/YYYY");

return (
<article className="container mx-auto max-w-2xl bg-white rounded shadow-lg hover:scale-105 hover:shadow-2xl transform transition-all duration-500 m-10">
<header className="flex items-center justify-between px-4">
<div className="flex justify-between items-center py-4">
<img className="w-12 rounded-full" src={logoImg} alt="logo" />
<div className="ml-3">
<h1 className="text-xl font-bold text-gray-800 cursor-pointer">
<h1 className="text-xl font-bold text-gray-800 cursor-pointer">
{post.author}
</h1>
<p className="text-sm text-gray-800 hover:underline cursor-pointer">
Expand Down Expand Up @@ -42,10 +43,13 @@ export function PostCardUser({ post }) {

<div className="p-6">
<h2 className="text-xl text-gray-800 font-semibold">{post.title}</h2>
<p className="text-lg font font-thin text-black text-justify">
<ReactMarkdown className="text-lg font font-thin text-black text-justify">
{post.description}
</p>
<h4 className="text-gray-400 capitalize my-2"> Source:{post.source}</h4>
</ReactMarkdown>
<h4 className="text-gray-400 capitalize my-2">
{" "}
Source: {post.source}
</h4>
</div>
</article>
);
Expand Down
9 changes: 5 additions & 4 deletions src/pages/PostForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { useState, useEffect } from "react";
import { Formik, Form, Field, ErrorMessage } from "formik";
import { usePosts } from "../context/postContext";
import { useNavigate, useParams } from "react-router-dom";
import * as Yup from "yup";
import { useEffect, useState } from "react";
import { Toaster, toast } from "react-hot-toast";
import { getPostsRequest } from "../api/posts";

Expand Down Expand Up @@ -38,7 +38,7 @@ export function PostForm() {
return (
<div className="flex items-center justify-center">
<div className="bg-blue-950 p-10 shadow-md shadow-black mt-7 animate-fade-down animate-once animate-duration-500 animate-ease-linear">
<header className="flex justify between items-center py-4 text-white">
<header className="flex justify-between items-center py-4 text-white">
<h3 className="text-xl">New Post</h3>
</header>

Expand Down Expand Up @@ -106,6 +106,7 @@ export function PostForm() {
name="description"
className="text-red-400 text-sm"
/>

<label
htmlFor="categories"
className="text-sm block font-bold text-gray-400"
Expand Down Expand Up @@ -167,9 +168,9 @@ export function PostForm() {
onChange={(e) => {
const selectedImage = e.target.files[0];
setFieldValue("image", selectedImage);

const imageUrl = URL.createObjectURL(selectedImage);

document.getElementById("image-preview").src = imageUrl;
Comment on lines 168 to 174
Copy link

@adonyssantos adonyssantos Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not recommended to use document when you are using React.

As an alternative

You can create a state using useState to save the image metadata, such as src or alt, and update the data using the setter.

Example

setImagePreview(prev => { ...prev, url: imageUrl });

You just have to use that state in the src of the image, like this:

<img src={imagePreview.src} alt={imagePreview.alt} />

There are more alternatives that I invite you to investigate and use the one you consider most convenient.

This does not belong to this feature, so I approve the PR and create an issue for you to work on, this is #39.

}}
/>
Expand Down