Skip to content

Refactor: improve image src update #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Refactor: improve image src update #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a63e2
Refactor: improve image src update
EdwinDev6 Oct 24, 2023
d6d16c6
Fix: bug in post images
EdwinDev6 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/pages/PostForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ export function PostForm() {
}
})();
}, [params.id, getPost]);

const [imagePreview, setImagePreview] = useState({
src: "",
alt: "original imagen",
});
return (
<div className="flex items-center justify-center">
<div className="bg-blue-950 p-10 shadow-md shadow-black mt-7 animate-fade-down animate-once animate-duration-500 animate-ease-linear">
Expand Down Expand Up @@ -171,15 +174,17 @@ export function PostForm() {

const imageUrl = URL.createObjectURL(selectedImage);

document.getElementById("image-preview").src = imageUrl;
setImagePreview((prev) => ({ ...prev, src: imageUrl }));
}}
/>
<img
id="image-preview"
src={post.image ? post.image.url : ""}
alt="original imagen"
style={{ maxWidth: "100%", maxHeight: "200px" }}
/>
{imagePreview.src || (post.image && post.image.url) ? (
<img
id="image-preview"
src={imagePreview.src || post.image.url}
alt={imagePreview.alt}
style={{ maxWidth: "100%", maxHeight: "200px" }}
/>
) : null}

<button
type="submit"
Expand Down