Skip to content

Conversation

@vkatkade-c-eightfold
Copy link
Contributor

@vkatkade-c-eightfold vkatkade-c-eightfold commented Jun 9, 2025

SUMMARY:

This PR adds support for passing a custom accessibility prop to the MdiIcon component through the iconProps prop. This allows for better accessibility customization of icons when needed.

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-147916

CHANGE TYPE:

  • Bugfix Pull Request
  • [. ] Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Screenshot 2025-06-13 at 11 42 20 AM

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ypatadia-eightfold ypatadia-eightfold self-requested a review June 10, 2025 18:10
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (7abf1b4) to head (48524b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   84.46%   84.45%   -0.01%     
==========================================
  Files        1104     1104              
  Lines       20694    20694              
  Branches     7843     7843              
==========================================
- Hits        17479    17478       -1     
- Misses       3127     3128       +1     
  Partials       88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ypatadia-eightfold ypatadia-eightfold merged commit cb17f8a into EightfoldAI:main Aug 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants