-
Notifications
You must be signed in to change notification settings - Fork 63
fix: icon: Add iconProps prop support to MdiIcon component #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ypatadia-eightfold
merged 22 commits into
EightfoldAI:main
from
vkatkade-c-eightfold:vkatkade/ENG-147916/icon
Aug 13, 2025
Merged
fix: icon: Add iconProps prop support to MdiIcon component #1005
ypatadia-eightfold
merged 22 commits into
EightfoldAI:main
from
vkatkade-c-eightfold:vkatkade/ENG-147916/icon
Aug 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sthakur-c-2-eightfold
approved these changes
Jun 13, 2025
ypatadia-eightfold
requested changes
Jun 28, 2025
…tfold/octuple into vkatkade/ENG-147916/icon
ypatadia-eightfold
requested changes
Jul 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.01%
==========================================
Files 1104 1104
Lines 20694 20694
Branches 7843 7843
==========================================
- Hits 17479 17478 -1
- Misses 3127 3128 +1
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tfold/octuple into vkatkade/ENG-147916/icon
ypatadia-eightfold
requested changes
Aug 12, 2025
…tfold/octuple into vkatkade/ENG-147916/icon
ypatadia-eightfold
requested changes
Aug 12, 2025
…tfold/octuple into vkatkade/ENG-147916/icon
ypatadia-eightfold
requested changes
Aug 13, 2025
…tfold/octuple into vkatkade/ENG-147916/icon
ypatadia-eightfold
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR adds support for passing a custom accessibility prop to the MdiIcon component through the iconProps prop. This allows for better accessibility customization of icons when needed.
GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-147916
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: