fix: removed ariaDescribedby on conditionally joined ariadescribedBy #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ypatadia-eightfold
requested changes
Aug 13, 2025
…ttps://github.com/speshkar-c-eightfold/octuple into speshkar/fixAriaDescribedby-forsubLabelAnnouncement
ypatadia-eightfold
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
ariaDescribedBy applied on TextInput only when mergedStatus = 'error'
added condition so that ariaDescribedBy applies on both error and subLabel
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-147969
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
For textInput aria-describedBy applied only when mergedstatus = error
passed aria-describedby to apply for sublabel text
check if aria-describedby applied to textInput