Skip to content

Conversation

@jgadewar-c-eightfold
Copy link
Contributor

@jgadewar-c-eightfold jgadewar-c-eightfold commented Jun 25, 2025

SUMMARY:

The tooltip component has role button applied to functionality when a div is hovered, fixed it conditionally based on trigger prop value.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-128605

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. Check for the TimeRangePicker component
  2. Check for the hover functionality on the Picker (Start time and End time)
  3. If the Picker opens a tooltip on hover, the role = button should not be applied

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 25, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ypatadia-eightfold ypatadia-eightfold self-requested a review June 25, 2025 18:39
@jgadewar-c-eightfold jgadewar-c-eightfold changed the title fix: update role to get applied conditionally and aria-describedBy fix: update role to get applied conditionally Jun 26, 2025
@ypatadia-eightfold ypatadia-eightfold merged commit ceba97f into EightfoldAI:main Aug 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants