Skip to content

Conversation

@jgadewar-c-eightfold
Copy link
Contributor

@jgadewar-c-eightfold jgadewar-c-eightfold commented Jun 27, 2025

SUMMARY:

  1. The announcement for the page button in the pagination component was not clear
  2. Updated the announment to include the number of pages

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-147174

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. Check for the Pagination Component
  2. Each button representing pages should announce, Page 1 of 5, current button, etc for the selected page
    Page 1 of 5 , button - for unselected page
Screen.Recording.2025-08-06.at.2.03.25.PM.mov

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ypatadia-eightfold ypatadia-eightfold self-requested a review June 27, 2025 21:47
@ypatadia-eightfold ypatadia-eightfold merged commit 7abf1b4 into EightfoldAI:main Aug 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants