Skip to content

Conversation

@krane-c-eightfold
Copy link
Contributor

SUMMARY:

  • Accordion was reading the header thrice in quick nav mode
  • it should read the header only twice one for label 2nd for region
  • a div with role button which was made clickable was causing the issue

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-154988

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • navigate to accordion component
  • turn on voiceover
  • turn on quick nav mode and check if accordion is getting focused twice
Screen.Recording.2025-07-30.at.4.43.31.PM.mov

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ypatadia-eightfold ypatadia-eightfold self-requested a review July 30, 2025 17:10
Copy link
Collaborator

@ypatadia-eightfold ypatadia-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Delete .clickable-area from accordion.module.scss if it's not used in the codebase anymore.
  2. add cursor: pointer to accordion header

@ypatadia-eightfold ypatadia-eightfold merged commit 24b56ef into EightfoldAI:main Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants