Skip to content

Conversation

@jgadewar-c-eightfold
Copy link
Contributor

SUMMARY:

  1. The click event listener is getting added for the non-interactive skill tags even if it don't have any clickable functionality.
  2. Fixed this by adding conditional rendering to only attach click handlers when the tag is actually interactive.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-155960

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. Select skillTag component from the storybook
  2. If the skillTag is not interactive , then div with a class = background should not have click events
  3. check on NVDA, it should not announce clickable skillName if it is not interactive
image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ypatadia-eightfold ypatadia-eightfold self-requested a review August 12, 2025 17:30
@ypatadia-eightfold ypatadia-eightfold merged commit 4c3c746 into EightfoldAI:main Aug 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants