-
Notifications
You must be signed in to change notification settings - Fork 63
feat(DatePicker): add accessibility announcement for arrow key navigation #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DatePicker): add accessibility announcement for arrow key navigation #1033
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I have verified the announcement with NVDA and without NVDA
@ychhabra-eightfold @pmahajan-eightfold Arrow.Navigation.for.Date.picker.mp4 |
mfazil-eightfold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 84.48% 84.45% -0.04%
==========================================
Files 1104 1104
Lines 20801 20824 +23
Branches 7877 7893 +16
==========================================
+ Hits 17573 17586 +13
- Misses 3140 3150 +10
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUMMARY:
This PR implements two key accessibility improvements for the DateTimePicker Range Picker component:
1. Focus Trap Support
trapFocusprop support toOcRangePicker(defaults tofalseto prevent regressions)FocusTrapcomponent wrapper when enabledtrapFocusprop2. Fixed Arrow Key Focus Behavior
useCellPropshook returnedundefinedfor range pickers, disabling focus management on date cellsuseCellPropsto always return cell props, enabling proper focus shifts to date cellspartialRefto range picker's PartialContext for complete focus management3. Announcement Support
announceArrowKeyNavigationprop support for range picker when dropdown opensResult: Range picker now has the same accessibility experience as single picker - arrow key navigation properly shifts focus to date cells and announces changes.
GITHUB ISSUE (Open Source Contributors)
N/A - Internal accessibility improvement
JIRA TASK (Eightfold Employees Only):
[Please fill in JIRA task number]
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Manual Testing
Focus Trap (when enabled):
trapFocus={true}Arrow Key Focus Behavior:
Announcement Support:
announceArrowKeyNavigation={true}Automated Testing
trapFocus={false}prevents any breaking changes