Skip to content

Conversation

@softworkz
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 15, 2025 07:33
Copilot finished reviewing on behalf of softworkz November 15, 2025 07:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the SOFTWORKZ-specific build configuration and consolidates the MSBuild files by inlining the content of ElectronNET.props and ElectronNET.targets directly into their respective .Core counterparts.

Key changes:

  • Removed the SOFTWORKZ conditional PropertyGroup from common.props
  • Consolidated ElectronNET.props content into ElectronNET.Core.props (removing the indirection)
  • Consolidated ElectronNET.targets content into ElectronNET.Core.targets (removing the indirection)
  • Updated development mode project references to use the .Core files directly

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/common.props Removed SOFTWORKZ conditional PropertyGroup configuration
src/ElectronNET/build/ElectronNET.targets Deleted file; content moved to ElectronNET.Core.targets
src/ElectronNET/build/ElectronNET.props Deleted file; content moved to ElectronNET.Core.props
src/ElectronNET/build/ElectronNET.Core.targets Replaced Import statement with inline content from ElectronNET.targets
src/ElectronNET/build/ElectronNET.Core.props Replaced Import statement with inline content from ElectronNET.props
src/ElectronNET.WebApp/ElectronNET.WebApp.csproj Updated development mode imports to reference .Core files
src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj Updated development mode imports to reference .Core files
src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj Updated development mode imports to reference .Core files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FlorianRappl FlorianRappl added this to the 0.2.0 milestone Nov 15, 2025
Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - much appreciated!

@FlorianRappl FlorianRappl merged commit 68c50f1 into ElectronNET:develop Nov 15, 2025
1 check passed
@FlorianRappl FlorianRappl mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants