-
-
Notifications
You must be signed in to change notification settings - Fork 739
Remove softworkz' special sauce #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove softworkz' special sauce #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the SOFTWORKZ-specific build configuration and consolidates the MSBuild files by inlining the content of ElectronNET.props and ElectronNET.targets directly into their respective .Core counterparts.
Key changes:
- Removed the SOFTWORKZ conditional PropertyGroup from common.props
- Consolidated ElectronNET.props content into ElectronNET.Core.props (removing the indirection)
- Consolidated ElectronNET.targets content into ElectronNET.Core.targets (removing the indirection)
- Updated development mode project references to use the .Core files directly
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common.props | Removed SOFTWORKZ conditional PropertyGroup configuration |
| src/ElectronNET/build/ElectronNET.targets | Deleted file; content moved to ElectronNET.Core.targets |
| src/ElectronNET/build/ElectronNET.props | Deleted file; content moved to ElectronNET.Core.props |
| src/ElectronNET/build/ElectronNET.Core.targets | Replaced Import statement with inline content from ElectronNET.targets |
| src/ElectronNET/build/ElectronNET.Core.props | Replaced Import statement with inline content from ElectronNET.props |
| src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | Updated development mode imports to reference .Core files |
| src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj | Updated development mode imports to reference .Core files |
| src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj | Updated development mode imports to reference .Core files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
72ad5e5 to
5305e17
Compare
FlorianRappl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - much appreciated!
No description provided.