Rename PropertyGet to more generic Invocator #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to rename PropertyGetter to the more generic Invocator, reflecting that this component is no longer used exclusively for property operations. The changes update the base API class and propagate through multiple API files.
Key Changes
- Renamed
PropertyGetterclass toInvocatorinApiBase.cs - Renamed
GetPropertyAsync<T>()method toInvokeAsync<T>() - Updated all API classes to use
this.InvokeAsync<T>()instead ofGetPropertyAsync<T>()
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET.API/API/ApiBase.cs | Core refactoring - renamed base class, methods, fields, and constants from PropertyGetter to Invocator terminology |
| src/ElectronNET.API/API/WebContents.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Screen.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Process.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Notification.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/NativeTheme.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Clipboard.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/BrowserWindow.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/BrowserView.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/AutoUpdater.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/App.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_invocation_rename
branch
from
1f496a2 to
0cf1e69
Compare
softworkz
force-pushed
the
submit_invocation_rename
branch
from
0cf1e69 to
385dcfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as it's no longer used for property operations only.