Skip to content

Put node alias and other human readable things in listpeers #1042

@Ulmo

Description

@Ulmo

Issue and Steps to Reproduce

listnodes command gives the alias of the node, which is nice. I recently was able to find out that a peer ID I was having trouble with is named VIOLENTROUTE, which we all know is a problematic peer. However, when I saw it in listpeers, it didn't occur to me until later to look up its alias, and since its alias wasn't in listpeers, it didn't automatically alert me to that issue.

Also, it would just be nice to see aliases in listpeers.

Downside: this could be an attack vector (it's easy to spoof an alias). If we think it is a huge attack vector, exclude it.

getinfo output

{ "id" : "031c527494f295220d26a1814c18e7db3f4f03203ce1a53a0b74b52ed570a3972a", "port" : 9735, "address" :
[
{ "type" : "ipv4", "address" : "24.4.228.213", "port" : 9735 } ], "version" : "v0.5.2-2016-11-21-2017-g4fccbba", "blockheight" : 509937, "network" : "bitcoin" }

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureAimed at improving the existing functionality or a new feature that provides additional valuehx G4OLabel hx used as 'good for onboarding' but some issues may not still be true to that definition.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions