libplugin: Instrument the JSON-RPC calls with tracing #7575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202408-trace-pay
branch
from
2a740b7 to
80c2c4b
Compare
The `send_outreq` function is a good place to suspend and resume traces, since these are usually the places where we hand off control back to the `io_loop`. This assumes that we do not continue doing heavy liftin after we have queued an `outreq` call, but that is most likely the case anyway. This frees us from having to track suspensions whenever we call the RPC from a plugin.
Having it in the header means we may end up including it multiple times, so move them into the compilation unit, where it'll only be compiled once, and therefore the linker does not get confused as much.
cdecker
force-pushed
the
202408-trace-pay
branch
from
57a9659 to
76a2c8c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #7556 and just moves the suspend / resume calls to the where we yield control to the
io_loopand when we come back through a callback call.