Fix listchannels includeprivate broken #7663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's an output field (which we don't complain about), not an input field! Fixes: ElementsProject#7652 Changelog-Fixed: Logging: removed bogus "**BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private" message. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
Type::Bug
Comment on lines
+4420
to
+4424
| def test_listchannels_broken_message(node_factory): | ||
| """This gave a bogus BROKEN message with deprecated-apis enabled""" | ||
| l1 = node_factory.get_node(options={'allow-deprecated-apis': True}) | ||
|
|
||
| l1.rpc.listchannels() |
There was a problem hiding this comment.
We may want to assert on the logs?
There was a problem hiding this comment.
Cleanup already does this automatically...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroneous check made us complain every time we output a deprecated field in listchannels.
Fixes: #7652