Towards better testing for routing, using a canned gossmap from my mainnet node. #7708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interestingly, compressed sizes don't change, but uncompressed does: ``` $ file /tmp/gs.out-wrongorder /tmp/gs.out-wrongorder: gzip compressed data, max compression, from Unix, original size modulo 2^32 1594822 $ ls -l /tmp/gs.out-wrongorder -rw-rw-r-- 1 rusty rusty 494337 Sep 20 13:34 /tmp/gs.out-wrongorder $ file /tmp/gs.out /tmp/gs.out: gzip compressed data, max compression, from Unix, original size modulo 2^32 1498634 $ ls -l /tmp/gs.out -rw-rw-r-- 1 rusty rusty 494353 Sep 20 13:33 /tmp/gs.out ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can only use the loop to iterate once. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…r compression. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There are some, they're unusable high-fee. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can run a lot of tests on this. Look at me, I'm number 3301! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We only ever visit each node once, so we can just use an array. This avoids calling tal() all the time, which is *especially* slow when we're memory tracking. I had an old canned gossmap which I benchmarked for these (and in particular one node was unreachable, and that was slow): Before: 17.27 seconds After: 5.80 seconds Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Lagrang3
reviewed
Oct 2, 2024
Lagrang3
reviewed
Oct 2, 2024
I like the clarity, but this is a hot path. Fortunately these arrays have very well defined lengths. Before: 5.81 seconds After: 1.06 seconds Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
canned-gossmap
branch
from
ac4a72e to
4aaa806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the gossmap-compress tool, places a compressed gossmap snapshot from my node in the tree (only 500k!) and then does some simply optimization to askrene's min-cost-flow solver based on a very simple python call to call getroutes on it.