Skip to content

Conversation

@ShahanaFarooqui
Copy link
Collaborator

Changelog-None.

@ShahanaFarooqui ShahanaFarooqui requested a review from cdecker July 10, 2025 04:56
@ShahanaFarooqui ShahanaFarooqui linked an issue Jul 10, 2025 that may be closed by this pull request
@rustyrussell rustyrussell added this to the v25.09 milestone Jul 11, 2025
@rustyrussell rustyrussell merged commit cea6c81 into ElementsProject:master Jul 11, 2025
76 of 78 checks passed
@michaelWuensch
Copy link

@ShahanaFarooqui
I am right now implementing the new URI Formats, but the certs parameter is not 100% clear.
Is the order always fixed? Because if not, I don't know how to distinguish between client cert and ca cert as both start with -----BEGIN CERTIFICATE-----
If the order is fixed and required that way, it would make sense to mention it in the docs.

Furthermore it is unclear if always all 3 certs are required/provided. For a Tor Connection for example the Ca cert is not necessary and just bloats the QR Code.

@ShahanaFarooqui
Copy link
Collaborator Author

ShahanaFarooqui commented Aug 6, 2025

@ShahanaFarooqui I am right now implementing the new URI Formats, but the certs parameter is not 100% clear. Is the order always fixed? Because if not, I don't know how to distinguish between client cert and ca cert as both start with -----BEGIN CERTIFICATE----- If the order is fixed and required that way, it would make sense to mention it in the docs.

The order is fixed and should have been mentioned in the doc. Thanks for raising it, I will update the doc soon.

Furthermore it is unclear if always all 3 certs are required/provided. For a Tor Connection for example the Ca cert is not necessary and just bloats the QR Code.

For now, I would prefer to keep all 3 for all connections. We can revisit the approach in future.

@michaelWuensch
Copy link

@ShahanaFarooqui Ok, perfect, that is all I need to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise and Document Connection URLs for CLN Tools/Plugins

3 participants