connectd: fix diagnostics if we get a long delay. #8525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a0fd72e I added a diagnostic message if messages cause large delays, *but* I didn't set the "peer_in_lasttime" variable in the case of locally-handled packets. I really want this in the release: the point of this was to try to diagnose some high-latency ping issues we've seen on the real network. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
ping-lag-diag
branch
from
4a84434 to
45844bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a0fd72e I added a diagnostic message if messages cause large delays, but I didn't set the "peer_in_lastmsg" variable in the case of locally-handled packets.
I really want this in the release: the point of this was to try to diagnose some high-latency ping issues we've seen on the real network.
Changelog-None