Skip to content

Giant tx fix #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Giant tx fix #8639

wants to merge 3 commits into from
+46 −15

Conversation

@rustyrussell
Copy link
Contributor

Fixes: #8634

@rustyrussell
common: remove tal_check() call on libwally allocations.
8f0a518 
We call it once at the end, but calling on each allocation is
excessive, and it shows when dealing with large PSBTS.  Testing a
700-input PSBT was unusably slow without this: after this the entire
test ran in 9 seconds.

Changelog-Fixed: JSON-RPC: Dealing with giant PSBTs (700 inputs!) is now much faster.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
pytest: test for bcli crash with huge PSBTs.
54a187c 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the v25.12 milestone Oct 28, 2025
@rustyrussell rustyrussell added the 25.09.2 Candidates if we do a 25.09.2 label Oct 28, 2025
@rustyrussell
plugins/bcli: use -stdin to feed arguments, in case we have a giant tx.
6c0eb3e 
```
lightningd-1 2025-10-27T11:26:04.285Z **BROKEN** plugin-bcli: bitcoin-cli exec failed: Argument list too long
```

Use -stdin to bitcoin-cli: we can then handle arguments of arbitrary length.

Fixes: ElementsProject#8634
Changelog-Fixed: plugins: `bcli` would fail with "Argument list too long" when sending a giant tx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wizgucci wizgucci wizgucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

25.09.2 Candidates if we do a 25.09.2

Projects

None yet

Milestone

v25.12

Development

Successfully merging this pull request may close these issues.

crash: /usr/local/bin/bitcoin-cli exec failed: Argument list too long

2 participants

@rustyrussell @wizgucci