Fix BOLT11 annotation loss after sendonion failure #8690
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ElementsProject#6978 where bolt11 annotations were lost when sendonion failed early and payment was retried. When sendonion RPC fails before saving payment to database, the invstring_used flag remained true, causing retry attempts to omit the bolt11 parameter. Successful retries would then save to DB without bolt11 annotation. The bug is visible in payment_createonion_success() (line 1772): flag is set before sendonion RPC completes. If sendonion fails immediately (e.g., no peer connection), flag remains true and retries omit bolt11. Fix: Reset invstring_used=false in payment_rpc_failure() when method is "sendonion", ensuring retry attempts include bolt11.
Contributor
|
Hmm, maybe we should do this differently? Only set the flag to true when sendonion succeeds? Sure, that means we will have redundant strings, but it will always be set? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6978 - Implements @rustyrussell's recommended fix to reset invstring_used flag on sendonion failure.