Export bitcoin dependency #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1. Can you add a commit which bumps the minor version so we can publish? |
apoelstra
approved these changes
Sep 20, 2019
Member
apoelstra
left a comment
apoelstra
left a comment
There was a problem hiding this comment.
Looks good. waiting on travis
stevenroose
force-pushed
the
export-bitcoin
branch
from
f73af5e to
f2c4744
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
@apoelstra Can this go in or is there something else that needs to go first? |
Member
|
I thought (from you) that we were waiting on #31? |
Contributor
Author
|
@apoelstra Ah huh I somehow closed that one. I didn't see it in the PR list so I thought it was merged. Yeah so that one please first. |
Collaborator
|
Looks like this needs another rebase |
stevenroose
force-pushed
the
export-bitcoin
branch
from
2996a64 to
f1f91d6
Compare
Contributor
Author
|
rebased |
jonasnick
added a commit
that referenced
this pull request
Oct 4, 2019
f1f91d6 Export bitcoin dependency (Steven Roose) Pull request description: We use the rust-bitcoin types. I know we should in the long term move away from that, but for now we still have several of the types that we reuse. Top commit has no ACKs. Tree-SHA512: da1905b574b4d575dcc28852f8992e2325c801124cca611755f0aec2e847c647ec0d6f01b0a60291211e46a51c78d669d0b9c9154410ba1e534e978d08098821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the rust-bitcoin types. I know we should in the long term move away from that, but for now we still have several of the types that we reuse.