Add some inspector methods to dynafed::Params + support root calculation #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
force-pushed
the
params-insepctors
branch
2 times, most recently
from
abd1fe5 to
4155708
Compare
stevenroose
changed the title
stevenroose
force-pushed
the
params-insepctors
branch
2 times, most recently
from
8462bd3 to
9b047fe
Compare
stevenroose
force-pushed
the
params-insepctors
branch
3 times, most recently
from
5f5792b to
0dde68f
Compare
jonasnick
reviewed
Sep 26, 2019
| }; | ||
| assert_eq!( | ||
| compact_entry.calculate_root().to_hex(), | ||
| "dff5f3793abc06a6d75e80fe3cfd47406f732fa4ec9305960ae2a229222a1ad5" |
Collaborator
There was a problem hiding this comment.
This doesn't appear to match elements test hash 4587cf1c2448740c3fe4bf0d3ab22f3f193b18f43c4ee47da3690c53becb7fa4?
Contributor
Author
There was a problem hiding this comment.
Ah yeah I forgot to update those after I changed the test. In this PR you can see the correct ones: https://github.com/ElementsProject/elements/pull/719/files
I'll fix this in a force-push.
stevenroose
force-pushed
the
params-insepctors
branch
from
0dde68f to
d7d5c5d
Compare
jonasnick
approved these changes
Sep 27, 2019
|
|
||
| #[test] | ||
| fn test_param_roots() { | ||
| // Taken from the following Elements Core test: |
Collaborator
There was a problem hiding this comment.
Would have been better I think to just include a github link to commit and line number. But not all that important.
Contributor
Author
There was a problem hiding this comment.
Yeah the test in Elements was still up for review and might not be merged or be changed in the future. I figured it's not that big so better just make sure to have it.
jonasnick
added a commit
that referenced
this pull request
Sep 27, 2019
…ot calculation d7d5c5d Support for calculating consensus params roots (Steven Roose) 2c9c2fb Add some inspector methods to dynafed::Params (Steven Roose) Pull request description: The Rust enum stuff is all fancy and such, but it's often a real pain in the ass to either just check which of the vairants is used or to get a field out if you already know what the variant is. ACKs for top commit: jonasnick: ACK d7d5c5d Tree-SHA512: 50dda4991cce964d6cfe102b20ee12d855565961df41989adb619f8f246bffc40fff8d93a3fed0c23e090d80091b3c94f23d7a0e6c9a59960029b467cf42db1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust enum stuff is all fancy and such, but it's often a real pain in the ass to either just check which of the vairants is used or to get a field out if you already know what the variant is.