Add Params::elided_root and Params::into_compact #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
changed the title
stevenroose
force-pushed
the
elided-root-getter
branch
from
02640d3 to
64ca109
Compare
This method is to be used to convert full params into compact params.
Member
|
lgtm. Want to add a commit that bumps the minor version? |
apoelstra
approved these changes
Nov 27, 2019
Member
apoelstra
left a comment
apoelstra
left a comment
There was a problem hiding this comment.
utACK. Steven says he has tested with real (daemon-provided) data elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I should have noticed this was missing while reviewing the PR that added the elided_root field. There are getters for all the other fields, so we should probably have this one. I already bumped into missing this one.