Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust-bitcoin v0.23 #37

Merged
merged 2 commits into from Jan 9, 2020
Merged

Conversation

@stevenroose
Copy link
Member

stevenroose commented Jan 9, 2020

No description provided.

stevenroose added 2 commits Jan 9, 2020
@apoelstra

This comment has been minimized.

Copy link
Member

apoelstra commented Jan 9, 2020

Looks good to me ... but arguably this crate should have its own blockhash/txid types to differentiate elements objects from bitcoin ones.

@apoelstra

This comment has been minimized.

Copy link
Member

apoelstra commented Jan 9, 2020

Gonna go ahead and merge this. We need to have a wider discussion about how bitcoin-specific the types representing pegin data should be (in principle we can support arbitrary other blockchains) and also how separate the Bitcoin and Elements types should be.

@apoelstra apoelstra merged commit b12613e into ElementsProject:master Jan 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.