Skip to content

Conversation

@Elijan9
Copy link
Owner

@Elijan9 Elijan9 commented May 26, 2021

Remove "include[]" parameter from call to "parts/match", this is likely only supported for pro customers. Fixes octopart#4

Remove "include[]" parameter from call to "parts/match",  this is likely only supported for pro customers. Fixes octopart#4
@Elijan9 Elijan9 merged commit 6290894 into master May 26, 2021
@robproject
Copy link

Thank you so much for this. How did you determine this was the issue? I'm very interested.

@Elijan9
Copy link
Owner Author

Elijan9 commented Jun 11, 2021

I debugged the issue in Visual studio, and when I found the request that was causing an error I reproduced the request that was failing and compared it to one I made myself and which was working. Knowing data sheets are only supported in the pro version, this was my first suspect. As I suspected, after removing "include[]" my reproduced request was no longer failing, so I removed it from the addin and everything we needed started working.

(BTW while the API is working we're still seeing some issues in the data content supplied by manufacturers, e.g. most only offer USD prices, one only has GBP and there's only one that actually has EUR prices, so we have to convert everything else from USD/GBP to EUR ourselves now. And we have set our country and currency in our preference.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR: Fatal error

3 participants